Review Request: Hide empty additional information lines in icons view mode

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106304/#review18407
-----------------------------------------------------------


Thanks for the patch, looks good! I have two small comments on the code.


dolphin/src/kitemviews/kstandarditemlistwidget.cpp
<http://git.reviewboard.kde.org/r/106304/#comment14517>

    I would write ... - (additionalRolesCount - emptyRolesCount) here. That makes it more obvious what happens IMHO.



dolphin/src/kitemviews/private/knepomukrolesprovider.cpp
<http://git.reviewboard.kde.org/r/106304/#comment14518>

    Hm, at first sight this looks like the loop does essentially nothing - if it finds an empty string in the hash, it puts an empty string with the same key into the hash. Am I overlooking something, or could the entire loop be removed?


- Frank Reininghaus


On Sept. 1, 2012, 12:17 p.m., Todd Jennings wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106304/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 12:17 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> Hide empty additional information lines in icons view mode.  Previously they were "-", which took up a lot of space while providing no additional information.
> 
> 
> This addresses bug 304752.
>     http://bugs.kde.org/show_bug.cgi?id=304752
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 0ae9b6bd3edf88ea48c40bb491ef9e57148b8062 
> 
> Diff: http://git.reviewboard.kde.org/r/106304/diff/
> 
> 
> Testing
> -------
> 
> Tested and it works
> 
> 
> Thanks,
> 
> Todd Jennings
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120901/7e8913ec/attachment.htm>