Review Request: KMainWindow: fix position support in --geometry option

[Dominik Haumann]

> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote:
> > Are you sure it fixes bug 165355 ? That bug tracks the issue about KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to the spawned process.
> 
> Christoph Feck wrote:
>     To clarify: I don't object to have this committed, but unless you clarify, how that bug is affected, it should not be closed. It is one of those bugs, where users would be highly irritated and frustrated, if it is marked as fixed, but actually still reproducible.
>     
>     From what I can tell, the newly marked duplicates are different bugs.

Agreed, will commit the patch as it is.

Still, in KDE 5, this feature is currently completely removed. So investing more time here does not make sense...


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107023/#review20817
-----------------------------------------------------------


On Oct. 24, 2012, 9:27 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107023/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 9:27 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KDE applications support the option: --geometry <width>x<height>{+-}<xpos>{+-}<ypos>
> Example: kwrite --geometry 800x600+100+100
> 
> While the width and height arguments work, the x/y positions only work if they are negative. The code was added 11 years ago with commit d3188ee411df716b20e10fcdaa9dbc506cc31759 and probably never worked. This patch tries to fix it.
> 
> In KDE 5, support for --geometry was removed with commit fbc835090758581ba57ffbd210c00e60b1e1742f in the frameworks branch. Still having a working version for the KDE 4 lifetime would be nice imo :-)
> 
> Related bug reports:
> - https://bugs.kde.org/show_bug.cgi?id=147094
> - https://bugs.kde.org/show_bug.cgi?id=165355
> 
> 
> This addresses bug 304279.
>     http://bugs.kde.org/show_bug.cgi?id=304279
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmainwindow.cpp 86ccab8 
> 
> Diff: http://git.reviewboard.kde.org/r/107023/diff/
> 
> 
> Testing
> -------
> 
> Not tested, since I have no KDE4 kdelibs build. It's very much appreciated, if someone else can test this.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121024/7aa214e7/attachment.htm>