Review Request: KMainWindow: fix position support in --geometry option

Dominik Haumann dhaumann at kde.org
Wed Oct 24 18:57:57 BST 2012



> On Oct. 24, 2012, 5:48 p.m., Thomas L├╝bking wrote:
> > kdeui/widgets/kmainwindow.cpp, line 456
> > <http://git.reviewboard.kde.org/r/107023/diff/1/?file=92237#file92237line456>
> >
> >     why 0?
> >     if the value is omitted that likely means "dont care, place regularily" - doesn't?

True, see updated patch.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107023/#review20809
-----------------------------------------------------------


On Oct. 24, 2012, 5:56 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107023/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 5:56 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KDE applications support the option: --geometry <width>x<height>{+-}<xpos>{+-}<ypos>
> Example: kwrite --geometry 800x600+100+100
> 
> While the width and height arguments work, the x/y positions only work if they are negative. The code was added 11 years ago with commit d3188ee411df716b20e10fcdaa9dbc506cc31759 and probably never worked. This patch tries to fix it.
> 
> In KDE 5, support for --geometry was removed with commit fbc835090758581ba57ffbd210c00e60b1e1742f in the frameworks branch. Still having a working version for the KDE 4 lifetime would be nice imo :-)
> 
> Related bug reports: https://bugs.kde.org/show_bug.cgi?id=147094
> 
> 
> This addresses bugs 165355 and 304279.
>     http://bugs.kde.org/show_bug.cgi?id=165355
>     http://bugs.kde.org/show_bug.cgi?id=304279
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmainwindow.cpp 86ccab8 
> 
> Diff: http://git.reviewboard.kde.org/r/107023/diff/
> 
> 
> Testing
> -------
> 
> Not tested, since I have no KDE4 kdelibs build. It's very much appreciated, if someone else can test this.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121024/fae77523/attachment.htm>


More information about the kde-core-devel mailing list