Review Request: Possibility to change an element ID of svg image in IconWidget

Dmitry Ashkadov dmitry.ashkadov at rosalab.ru
Wed Oct 24 14:02:32 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107017/
-----------------------------------------------------------

(Updated Oct. 24, 2012, 1:02 p.m.)


Review request for kdelibs and Plasma.


Changes
-------

IconWidget's properties 'svg' and 'elementId' should be independent


Description
-------

New System tray uses IconWidget QML item, but it isn't possible to set svg image with specified element id. Now I use Svg QML item to load svg and then pass icon to IconWidget, moreover svg is converted to pixmap (: . At the same time IconWidget can handle svg images, so these small changes make me happy :) because I will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. 


Diffs (updated)
-----

  plasma/widgets/iconwidget.h 78f392e 
  plasma/widgets/iconwidget.cpp a2092a4 

Diff: http://git.reviewboard.kde.org/r/107017/diff/


Testing
-------


Thanks,

Dmitry Ashkadov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121024/d46e9a8a/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list