Review Request: Activities support for Konqueror

[Ivan Čukić]

> On Oct. 18, 2012, 9:20 a.m., David Faure wrote:
> > Well if this works, ship it. I'm confused about this stuff though, it only says "this view has focus", but how does it get information about the current url etc?

The url is set in:
int KonqView::openUrl( const KUrl &url, const QString & locationBarURL, ... )
(lines 231-239)


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106908/#review20540
-----------------------------------------------------------


On Oct. 17, 2012, 4:06 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106908/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 4:06 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> Konqueror reports the open/close document events to activity manager daemon.
> 
> By knowing which window contains which documents and which one is in focus, we can do the following:
> 
> - collect the statistics about visited pages. Further, this provides a score for each document visited, that depends on the number of times it was open, the time the user spent on that location, and the time passed since the last visit.
> - availability of a global/workspace applet that allows sharing the current document via e-mail, social networks; bookmarking and rating the link, or connecting it to the current activity. (advantage of this is a unified UI for sharing/rating/linking that works with any application)
> - jump-lists (not impl. yet in plasma) to list top rated documents on a launcher icon or in the task manager applet
> - krunner can sort the documents based on the score
> - more things that I haven't thought of yet
> 
> There is no need to *use* ativities to have these benefits. Activities just serve as manual data clustering to provide more useful scores compared to the one-activity approach.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/CMakeLists.txt 529909d 
>   konqueror/src/konqview.h 45c5bde 
>   konqueror/src/konqview.cpp 2ee9896 
> 
> Diff: http://git.reviewboard.kde.org/r/106908/diff/
> 
> 
> Testing
> -------
> 
> The event reporting was watched in two ways:
> - by using the SLC applet (planned to be included in 4.10, currently plasma-mobile) - when konqueror opens a url, the icons light-up and when clicking on an icon, it show whether it reports the document properly
> - by using sqlite3 to browse the .kde/share/apps/activitymanager/resources/database - 'select * from nuao_DesktopEvent;'
> 
> Konqueror was used to open webpages and local directories; urls were opened in multiple windows, multiple tabs, or split-views, and both open/close and focusin/focusout events were registered correctly.
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121018/1afddb35/attachment.htm>