Review Request: Do not copy or move keys that don't actually exist

Albert Astals Cid tsdgeos at terra.es
Mon Oct 15 22:35:13 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106906/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Description
-------

When running kconf_update, if a source key does not exist it was creating a destination one with an empty string, which is totally wrong. This patch skips copyOrMove to do anything if the source key does not exist


Diffs
-----

  kconf_update/kconf_update.cpp 1bea77f 
  kconf_update/tests/test_kconf_update.cpp de14edb 

Diff: http://git.reviewboard.kde.org/r/106906/diff/


Testing
-------

Ran okular migration script successfully
added unittest


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121015/fe5cd27f/attachment.htm>


More information about the kde-core-devel mailing list