Review Request: Device notifier: show mounted device and path

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106755/
-----------------------------------------------------------

(Updated Oct. 12, 2012, 9:41 a.m.)


Review request for KDE Base Apps and Plasma.


Changes
-------

Here's the ultimate minimal version - showing the mount point info in the hover tooltip over the free space bar.


Description
-------

If a removable device is mounted using the Plasma device notifier, there is no indication of what the Unix name of the device is or where it is mounted.  This information may be useful to the user for (a) accessing the mounted device from non-KDE applications, or (b) troubleshooting mounting or unmounting problems.

The attached patch shows this information when the device is hovered over, just above the "N actions for this device" text.  Depending on whether or not the device is mounted, there are three possibilities that can be shown here:

  /dev/XXX                           when not mounted
  /dev/XXX mounted on /media/YYYY    when mounted
  /dev/XXX mounted                   if mounted but the mount point is not available

Please be gentle, this is my first QML patch :-)


This addresses bug 196939.
    http://bugs.kde.org/show_bug.cgi?id=196939


Diffs (updated)
-----

  plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 2a9b3f7 

Diff: http://git.reviewboard.kde.org/r/106755/diff/


Testing
-------

Built kde-workspace with this change, observed operation and display of device notifier with a selection of removable devices.


Screenshots (updated)
-----------

Device notifier with mounted device
  http://git.reviewboard.kde.org/r/106755/s/756/
Tooltip with mounted device
  http://git.reviewboard.kde.org/r/106755/s/769/


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121012/150e77ff/attachment.htm>