Review Request: Make sure KPropertiesDialog inherits the 'Categories' property when creating a new desktop file from an existing one

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106771/#review20113
-----------------------------------------------------------


This is a never-ending issue. Initially, local desktop files were merged with global desktop files, when parsing them, so such copying was unnecessary.
Then ksycoca changed (probably with the vfolder implementation), and it now stores full paths to desktop files, so they have to be standalone.
This makes things more robust, though, because the global file can disappear at the next upgrade, and the local one will keep working.
But this means it should be a full copy. Not just categories should be added, but everything, using KConfig::copyTo().

- David Faure


On Oct. 8, 2012, 5:53 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106771/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 5:53 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch make sure the Categories properties is inherited when a new local dekstop file is created from an existing one. It fixes the bug mentioned in bug# 286717.
> 
> 
> This addresses bug 286717.
>     http://bugs.kde.org/show_bug.cgi?id=286717
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kpropertiesdialog.cpp feb0c9e 
> 
> Diff: http://git.reviewboard.kde.org/r/106771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121009/cf639159/attachment.htm>