RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

[Aleix Pol]

On Mon, Oct 8, 2012 at 10:40 PM, Albert Astals Cid <aacid at kde.org> wrote:
> Hi fellow kde-core-develers, i was thinking that from time to time someone
> commits some code that breaks the building of the tests.
>
> This happens because people is not aware that those parts are unit tested.
>
> I think that by enabling the building of the tests by default we at least make
> sure the tests will build and maybe when people see their code actually
> breaking the compilation of a unit test we get them to run them and maybe even
> improve them :-)
>
> Of course, enabling building the tests by defaults makes compilation times a
> bit longer, but I do think that the benefits far surpass the problems and for
> people with really slow machines and/or needs to recompile stuff a lot there
> is always the possibility that they can ask cmake not to build the tests.
>
> Comments?
>
> Cheers,
>   Albert

+1 for always building unit tests!
Actually I've always been unsure why packagers don't run unit tests...
Maybe this would help.

FWIW, in KDevelop we're already setting KDE4_BUILD_TESTS=ON.

Aleix