[PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.
mpyne at kde.org
Mon Oct 8 19:09:58 BST 2012
On Sunday, October 07, 2012 22:23:56 Jon Severinsson wrote:
> The sign of the UTC offset was ignored, and an offset of -0500 (New York)
> would be treated at +0500 (Pakistan). This commit also adds a unit test for
> UTC offset parsing and comparasion. ---
> When mucking around in the frameworks branch of kdelibs I found a bug in the
> KDateTime string parsing, which appears to be present in master as well as
> every branch from 4.0 to 4.10. I have, however, only run the updated
> unittest using the frameworks branch and Qt5, so someone else should
> probably test on 4.9, 4.10 and/or master before committing it.
I've adapted the patch slightly to the 4.9 testsuite and I have verified that
the new test does fail without your patch, and passes with it.
I can commit the test and fix to 4.9 and 4.10, but I would like it if someone
with experience in the date/time code could review first. The fix makes sense
to me, I just don't know if there are other affected areas or unintended
breakage that would be experienced. I've CC'ed David Jarvie but anyone else
with experience can chime in too. :P
- Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel