Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

Bernd Buschinski b.buschinski at googlemail.com
Sun Oct 7 23:17:12 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104243/
-----------------------------------------------------------

(Updated Oct. 7, 2012, 10:17 p.m.)


Review request for kdelibs.


Changes
-------

- regenerated with bison 2.6.2
- updated broken ch07 tests (no new fails, just fixes, reorder caused some noise)


Description
-------

KJS/Grammar: Introduce new non-terminal IdentifierName,
which allows keywords to be used as PropertyName, in Memberexps and CallExpr.
(but not yet enum,export,extends, super, because they have the same value RESERVED)


Diffs (updated)
-----

  kjs/grammar.h 5422fc7 
  kjs/grammar.cpp 71245a4 
  kjs/grammar.y d5e835f 
  kjs/tests/ecmatest_broken_ch07 bcc238d 

Diff: http://git.reviewboard.kde.org/r/104243/diff/


Testing
-------

Tested with ecmascript262, all keyword cases pass now, except the reserved ones


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121007/9387f61c/attachment.htm>


More information about the kde-core-devel mailing list