Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

Dawit Alemayehu adawit at kde.org
Tue Oct 2 21:56:26 BST 2012



> On Oct. 2, 2012, 8:57 a.m., David Faure wrote:
> > konqueror/src/konqsessionmanager.cpp, line 257
> > <http://git.reviewboard.kde.org/r/106503/diff/4/?file=88056#file88056line257>
> >
> >     in the... ? :-)
> >     
> >     (unfinished sentence)
> >     
> >     It's easier to just move the connect to the block that creates the widget, anyway. No if() needed, then.

That was done on purpose. If we connect to the itemChanged signal when we create the tree widget, then everytime we call QTreeWiegdtItem::setCheckState(...), the signal will fire and we do not want that. I have updated the comment to reflect just that and I have moved the connection right below the tree widget creation.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review19731
-----------------------------------------------------------


On Oct. 1, 2012, 8:56 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 8:56 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.
> 
> 
> This addresses bug 260282.
>     http://bugs.kde.org/show_bug.cgi?id=260282
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqsessionmanager.cpp 68a003f 
>   konqueror/src/konqsessionmanager.h ee629e4 
> 
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
> 
> 
> Testing
> -------
> 
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
> 
> 
> Screenshots
> -----------
> 
> old restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/729/
> new restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/731/
> new restore dialog v2
>   http://git.reviewboard.kde.org/r/106503/s/739/
> new restore dialog v3
>   http://git.reviewboard.kde.org/r/106503/s/750/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121002/97b50c80/attachment.htm>


More information about the kde-core-devel mailing list