Review Request: Make KFileDialog remember settings

[Aurélien Gâteau]

> On Oct. 2, 2012, 10:55 a.m., David Faure wrote:
> > kfile/kfilewidget.cpp, line 1875
> > <http://git.reviewboard.kde.org/r/106581/diff/3/?file=88080#file88080line1875>
> >
> >     OK, I was about to react against the move to a member variable configGroup (which basically means "accept() will use the last group that was passed to the public readConfig method"), but in fact I found the commit log for the addition of the public readConfig, and that's apparently what was wanted...
> >     
> >     commit 245888935048691e65a89ad8786b896d7bb3be7d
> >     Author: Andreas Pakulat <apaku at gmx.de>
> >     Date:   Tue Jun 30 20:35:49 2009 +0000
> >     
> >         Provide a readConfig method so one can let the widget read its config from a
> >         custom config group. Useful when embedding this widget somewhere else than the
> >         kfiledialog.
> >     
> >     OK then. But maybe Apaku should review this too :)

Since the code comes from Apaku I realized it must be related to the open project dialog in KDevelop. It is indeed used here: http://lxr.kde.org/source/extragear/kdevelop/kdevplatform/shell/openprojectpage.cpp#70

With the changes I propose, view settings are always saved to kdeglobals/[KFileDialog Settings], even if KFileWidget::readConfig() was called. Would it make more sense to save view settings to the custom config group in this case?


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106581/#review19741
-----------------------------------------------------------


On Oct. 2, 2012, 10:55 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106581/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 10:55 a.m.)
> 
> 
> Review request for kdelibs and Andreas Pakulat.
> 
> 
> Description
> -------
> 
> This patch makes KFileDialog remember settings such as which view mode is selected and whether the places sidebar should be visible.
> 
> Original code tried to save those to kdeglobals so that changes would be shared among all applications but it did so the wrong way. The patch writes the configuration to kdeglobals correctly, but saves the KDirOperator to the application config file (KDirOperator configuration settings are sort settings, show preview, show hidden files, view style (icon, detail, treeview))
> 
> There are two reasons for not saving KDirOperator config to kdeglobals:
> 
> 1. It is right now not possible to tell KDirOperator::writeConfig() to save to kdeglobals. It could be done by adding a new version of writeConfig() which would accept a KConfigBase::WriteFlags argument though.
> 
> 2. It probably would not be a good idea to remember KDirOperator settings globally anyway because depending on the application one may want to use different settings.
> For example if user wants to select images or videos he might set the file dialog to show big icons and the preview pane (so that videos can be played). This setup would however not be adapted in an application where one wants to select a text file.
> 
> 
> This addresses bug 139475.
>     http://bugs.kde.org/show_bug.cgi?id=139475
> 
> 
> Diffs
> -----
> 
>   kfile/kfilewidget.cpp 8e2f967 
> 
> Diff: http://git.reviewboard.kde.org/r/106581/diff/
> 
> 
> Testing
> -------
> 
> Tested with two different KDE applications. Settings are correctly remembered.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121002/60ff088e/attachment.htm>