Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review19731
-----------------------------------------------------------



konqueror/src/konqsessionmanager.h
<http://git.reviewboard.kde.org/r/106503/#comment15700>

    Remove the WFlags stuff, it's a Qt3 thing that is not even used in this code anyway (I know, KDialog still has it, but that's for compat reasons).



konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15704>

    Does this really make any difference? Widgets are transparent by default, in Qt4...



konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15705>

    Another approach (slightly faster, and with less risks of memory leaks) would be to create windowItem on demand, inside the inner loop, and do
    if (windowItem) {...}
    here.



konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15703>

    checked(bool) is slightly easier to handle than stateChanged(int), as long as you don't use tristate checkboxes.



konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15701>

    This code knows what defaultCode is set to ... it was set to KDialog::Yes earlier. So this can be simplified to
    setButtonFocus(KDialog::Yes), probably just after the setDefaultButton line.



konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15702>

    in the... ? :-)
    
    (unfinished sentence)
    
    It's easier to just move the connect to the block that creates the widget, anyway. No if() needed, then.


- David Faure


On Oct. 1, 2012, 8:56 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 8:56 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.
> 
> 
> This addresses bug 260282.
>     http://bugs.kde.org/show_bug.cgi?id=260282
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqsessionmanager.cpp 68a003f 
>   konqueror/src/konqsessionmanager.h ee629e4 
> 
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
> 
> 
> Testing
> -------
> 
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
> 
> 
> Screenshots
> -----------
> 
> old restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/729/
> new restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/731/
> new restore dialog v2
>   http://git.reviewboard.kde.org/r/106503/s/739/
> new restore dialog v3
>   http://git.reviewboard.kde.org/r/106503/s/750/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121002/14e167fb/attachment.htm>