Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

[Dawit Alemayehu]

> On Sept. 29, 2012, 9:20 a.m., David Faure wrote:
> > konqueror/src/konqsessionmanager.cpp, line 450
> > <http://git.reviewboard.kde.org/r/106503/diff/3/?file=87618#file87618line450>
> >
> >     Doesn't this lose ItemIsSelectable? I guess item->flags() | Qt::ItemIsUserCheckable would be better.

I did this on purpose. I do not want the items to be selectable. I just want them to be checkable.


> On Sept. 29, 2012, 9:20 a.m., David Faure wrote:
> > konqueror/src/konqsessionmanager.cpp, line 339
> > <http://git.reviewboard.kde.org/r/106503/diff/3/?file=87618#file87618line339>
> >
> >     This code would be better with a KDialog subclass, rather than with all the code in a function -- and then you need a slot in the calling class, and an ugly qobject_cast<window()>...
> >     
> >     If you split this up into a proper class, then it can have its own slots and member variables, and this will increase modularity and reusability. (and readability).
> >     
> >     Thanks.

Good point. I will redo it that way then.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review19563
-----------------------------------------------------------


On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 4:45 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.
> 
> 
> This addresses bug 260282.
>     http://bugs.kde.org/show_bug.cgi?id=260282
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqsessionmanager.h ee629e4 
>   konqueror/src/konqsessionmanager.cpp 68a003f 
> 
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
> 
> 
> Testing
> -------
> 
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
> 
> 
> Screenshots
> -----------
> 
> old restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/729/
> new restore dialog
>   http://git.reviewboard.kde.org/r/106503/s/731/
> new restore dialog v2
>   http://git.reviewboard.kde.org/r/106503/s/739/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121001/f4a8e4a2/attachment.htm>