Review Request: Improve mimetype detection for wevdav:// links

Sergey Borovkov serge.borovkov at gmail.com
Thu Nov 29 17:42:01 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107518/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

KIO::mimetype() when used on webdav:// url returned empty string on some servers, empty string on others. After some investigating I found out that mime-type is determined like for usual http:// links - i.e. making HEAD requests.
But this is problematic - some servers do not return content type for webdav links (for example this behavior occurred on webdavs://webdav.yandex.ru). Even if server returns content-type it can be wrong - for directories HEAD request return text/xml (that happens because webdav directories are simply xml listings).
I tried to fix this by essentially calling stat on webdav url and emitting mimetype when it's found.


Diffs
-----

  kioslave/http/http.h 4d0b029 
  kioslave/http/http.cpp b7f8e8d 

Diff: http://git.reviewboard.kde.org/r/107518/diff/


Testing
-------

Tested this on two webdav servers (webdavs://webdav.yandex.ru and webdavs://dav.2safe.com).


Thanks,

Sergey Borovkov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121129/f3b519a5/attachment.htm>


More information about the kde-core-devel mailing list