Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

Commit Hook null at kde.org
Fri Nov 23 11:55:45 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/#review22420
-----------------------------------------------------------


This review has been submitted with commit 0c0fa84c01d245e9acdff0d1d9664a108b981740 by Jan Grulich to branch KDE/4.10.

- Commit Hook


On Nov. 23, 2012, 11:12 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107413/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 11:12 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some KControl modules (i.e color scheme) to fix the problem when the list with widgets is not downloaded every time you open it.
> Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021
> 
> 
> Diffs
> -----
> 
>   plasma/private/packages.cpp 2519341 
> 
> Diff: http://git.reviewboard.kde.org/r/107413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121123/e8525f16/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list