Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage
Jan Grulich
grulja at gmail.com
Fri Nov 23 09:39:55 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/
-----------------------------------------------------------
(Updated Nov. 23, 2012, 9:39 a.m.)
Review request for kdelibs and Plasma.
Changes
-------
It seems that the solution will be easier. Connecting finished() signal to deleteLater() works.
Description
-------
Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some KControl modules (i.e color scheme) to fix the problem when the list with widgets is not downloaded every time you open it.
Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021
Diffs (updated)
-----
plasma/private/packages.cpp 2519341
Diff: http://git.reviewboard.kde.org/r/107413/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121123/938bd108/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
More information about the kde-core-devel
mailing list