Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/#review22405
-----------------------------------------------------------



plasma/private/packages.cpp
<http://git.reviewboard.kde.org/r/107413/#comment17178>

    and this blocks the entire UI which is not acceptable .. which is why show rather than exec is used.


- Aaron J. Seigo


On Nov. 22, 2012, 7:08 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107413/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 7:08 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some KControl modules (i.e color scheme) to fix the problem when the list with widgets is not downloaded every time you open it.
> Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021
> 
> 
> Diffs
> -----
> 
>   plasma/private/packages.cpp 2519341 
>   plasma/private/packages_p.h 15fde41 
> 
> Diff: http://git.reviewboard.kde.org/r/107413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121123/4233f0d2/attachment.htm>