Review Request: Remove usage of KIO::SlaveConfig from Dolphin

[David Faure]

> On Nov. 22, 2012, 7:45 p.m., David Faure wrote:
> > This probably needs a #ifdef on the kdelibs version number, then, since apparently kde-baseapps master only requires kdelibs-4.8...
> > 
> > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, but that wouldn't help anyway.
> >
> 
> Albert Astals Cid wrote:
>     Because when i sent an email to k-c-d with "Dependency Freeze for 4.10 in two weeks" asking for depencies like that to be increased noone suggested changing it
>
> 
> Frank Reininghaus wrote:
>     Thanks Dawit for implementing this!
>     
>     About the kdelibs version issue: wouldn't the easiest solution be to raise the version requirement once master is open again and push the patch to master then? It won't hurt much if the KIO::SlaveConfig call stays in the 4.10 branch, right?

Sounds like a plan.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107421/#review22391
-----------------------------------------------------------


On Nov. 22, 2012, 5:26 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107421/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 5:26 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The attached patch ports Dolphin away from using KIO::SlaveConfig::configData into the newly added KProtocolManager::charsetFor API. KIO::SlaveConfig was never intended to be a public class and as such it is going to go away in KF5.
> 
> Please note that you need to latest kdelibs from the 4.10 branch in order to compile this change.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinremoteencoding.cpp 375b3fd 
> 
> Diff: http://git.reviewboard.kde.org/r/107421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121122/b923c3c3/attachment.htm>