Review Request: Remove usage of KIO::SlaveConfig from Dolphin

Dawit Alemayehu adawit at kde.org
Thu Nov 22 17:26:30 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107421/
-----------------------------------------------------------

Review request for KDE Base Apps, David Faure and Frank Reininghaus.


Description
-------

The attached patch ports Dolphin away from using KIO::SlaveConfig::configData into the newly added KProtocolManager::charsetFor API. KIO::SlaveConfig was never intended to be a public class and as such it is going to go away in KF5.

Please note that you need to latest kdelibs from the 4.10 branch in order to compile this change.


Diffs
-----

  dolphin/src/views/dolphinremoteencoding.cpp 375b3fd 

Diff: http://git.reviewboard.kde.org/r/107421/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121122/74c8ea91/attachment.htm>


More information about the kde-core-devel mailing list