Review Request: port sonnet away from i18nc

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107412/#review22346
-----------------------------------------------------------



staging/sonnet/src/core/loader.cpp
<http://git.reviewboard.kde.org/r/107412/#comment17157>

    You're mixing context (= class name in Qt itself, empty in KF5) and disambiguation (= "comment").
    
    This should be
    QCoreApplication::translate("", variantEnglish, "dictionary variant").
    
    Same for all other i18nc calls ported to translate...


- David Faure


On Nov. 21, 2012, 7:47 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107412/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 7:47 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> port sonnet away from i18nc.
> 
> 
> Diffs
> -----
> 
>   staging/sonnet/src/core/loader.cpp 887aee5 
> 
> Diff: http://git.reviewboard.kde.org/r/107412/diff/
> 
> 
> Testing
> -------
> 
> it builds.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121121/a6288d45/attachment.htm>