Review Request: Jar archives also uses the zip protocol.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101455/#review22318
-----------------------------------------------------------


Hmm, this shouldn't be necessary, in fact.

The mimetype definition file freedesktop.org.xml says that application/x-java-archive derives from application/zip. So it sounds more like the code that looks at this field doesn't take mimetype inheritance into account?

That would be KProtocolManager::protocolForArchiveMimetype() in kio.
Indeed, it should look at parent mimetypes too, for this to work more generally.
Can you test this patch instead? http://www.davidfaure.fr/2012/188989.diff
Please check that everything works ok with zip-based documents, like openoffice files etc.

- David Faure


On May 27, 2011, 11:06 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101455/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 11:06 p.m.)
> 
> 
> Review request for KDE Runtime and David Faure.
> 
> 
> Description
> -------
> 
> nt
> 
> 
> This addresses bug 188989.
>     http://bugs.kde.org/show_bug.cgi?id=188989
> 
> 
> Diffs
> -----
> 
>   kioslave/archive/zip.protocol ce7c54b 
> 
> Diff: http://git.reviewboard.kde.org/r/101455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias Fuchs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121121/ff7ed9e7/attachment.htm>