Review Request: favicon local cache

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107358/#review22267
-----------------------------------------------------------

Ship it!


Looks good, thanks.


kdecore/services/kmimetype.cpp
<http://git.reviewboard.kde.org/r/107358/#comment17133>

    Wow...



kdecore/services/kmimetype.cpp
<http://git.reviewboard.kde.org/r/107358/#comment17134>

    Spaces around the '=' and '<' signs are missing, in all the newly added code.


- David Faure


On Nov. 20, 2012, 7:34 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107358/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 7:34 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Does not fix the bugs (I'll not mark them as fixed), but makes them much harder to reproduce.
> Just use a static QHash most of the time instead of a blocking Dbus call.
> 
> 
> This addresses bugs 306338 and 307973.
>     http://bugs.kde.org/show_bug.cgi?id=306338
>     http://bugs.kde.org/show_bug.cgi?id=307973
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kmimetype.cpp 955bf62 
> 
> Diff: http://git.reviewboard.kde.org/r/107358/diff/
> 
> 
> Testing
> -------
> 
> In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121120/40955a94/attachment.htm>