Review Request: QtWebKit is needed but not required bei CMakeList.txt

David Faure faure at kde.org
Mon Nov 19 16:50:47 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107386/#review22216
-----------------------------------------------------------

Ship it!


Thanks. Description could be improved a bit, but let's not nitpick.

- David Faure


On Nov. 19, 2012, 4:12 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107386/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 4:12 p.m.)
> 
> 
> Review request for kdelibs, David Faure and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Some files, such as kdewebkit/kwebwallet.h, need some h-file from QtWebKit, but this is not yet required from CMakeLists.txt 
> 
> 
> Diffs
> -----
> 
>   kdewebkit/CMakeLists.txt a11e572 
> 
> Diff: http://git.reviewboard.kde.org/r/107386/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121119/8326b9ef/attachment.htm>


More information about the kde-core-devel mailing list