Review Request: Fix sizing of KMessageWidget when shown at startup

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107336/#review22211
-----------------------------------------------------------

Ship it!


This fixes the sizing problems for KMessageWidget that we have in Kate.
Your patch simply uses the "best height" in two places now, instead of just one.
I've tested it and it works as expected, so I'd say ship it :-)

- Dominik Haumann


On Nov. 15, 2012, 12:47 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107336/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 12:47 p.m.)
> 
> 
> Review request for kdelibs and Dominik Haumann.
> 
> 
> Description
> -------
> 
> When a KMessageWidget is shown at startup, the content width is not correct: it stays at 640 pixels. Attached patch fixes this. Unless someone objects, I'd like to merge it in KDE/4.9.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmessagewidget.cpp b87b3e4 
> 
> Diff: http://git.reviewboard.kde.org/r/107336/diff/
> 
> 
> Testing
> -------
> 
> Have been running with this patch since for almost a week now. No regressions.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121119/76f9d5a8/attachment.htm>