Avoid QDBusConnection Qt warning message for each KUniqueApplication
Thiago Macieira
thiago at kde.org
Sat Nov 17 15:22:34 GMT 2012
On sábado, 17 de novembro de 2012 10.55.01, David Faure wrote:
> My current broken patch is
> http://www.davidfaure.fr/2012/kuniqueapp_broken_fix.diff
>
> The change from QDBusConnectionInterface* to QDBusConnection as the return
> value of tryToInitDBusConnection() -- which introduces a bit of noise in
> the patch -- is only due to the very last hunk: so that we can make the
> call from parent to child using the private connection rather than
> sessionBus().
The part in kuniqueapplication.cpp is evident, but I haven't got a clue what
you're trying to do in kapplication.cpp. You'll need to explain.
The rest looks ok.
Looking at the code today I see many uses of ::exit in both sides of the fork,
which is bad. This should be cleaned up, but since it's been like that for
ages, let's just leave it.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121117/d2d4d60b/attachment.sig>
More information about the kde-core-devel
mailing list