Review Request: Respect PYTHONDONTWRITEBYTECODE env variable

Luca Beltrame einar at heavensinferno.net
Tue Nov 6 22:49:23 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107228/#review21511
-----------------------------------------------------------

Ship it!


Good catch, I missed that. Push to 4.9: as I'm not sure it would merge cleanly as I changed a bit of things in 4.10, CC me in the commit and I'll see about trying to adapt it.

- Luca Beltrame


On Nov. 6, 2012, 10:50 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107228/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 10:50 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> cmake/modules/PythonMacros.cmake defines PYTHON_INSTALL macro. This macro should not create/install byte-compiled Python modules (*.pyc) when PYTHONDONTWRITEBYTECODE environmental variable is set.
> 
> See also: http://docs.python.org/using/cmdline.html#envvar-PYTHONDONTWRITEBYTECODE
> 
> patch by Arfrever Frehtes Taifersar Arahesis, I just updated it to be applied to master/KDE4.9
> 
> 
> This addresses bug 276151.
>     http://bugs.kde.org/show_bug.cgi?id=276151
> 
> 
> Diffs
> -----
> 
>   cmake/modules/PythonMacros.cmake 661e32d 
> 
> Diff: http://git.reviewboard.kde.org/r/107228/diff/
> 
> 
> Testing
> -------
> 
> Works. kdelibs Arch Linux package uses it since 4.8.4
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121106/5d4ccfca/attachment.htm>


More information about the kde-core-devel mailing list