Review Request: remove an assert
David Edmundson
david at davidedmundson.co.uk
Tue Nov 6 06:46:00 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107211/#review21475
-----------------------------------------------------------
The responsibility of deleting d->rootDir seems to lie within KArchive. Therefore by setting the rootDir twice either implicitly or explicitly (which this assert is designed to avoid) you risk leaking the first KArchiveDirectory object.
I think you need something more involved than just removing the checks.
- David Edmundson
On Nov. 5, 2012, 2:47 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107211/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 2:47 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> I've suffered this assert starting kdevelop.
> The assert and the comment are no longer valid, as the rootDir can be set also calling rootDir, not only setRootDir.
>
>
> Diffs
> -----
>
> kdecore/io/karchive.cpp 43539e3
>
> Diff: http://git.reviewboard.kde.org/r/107211/diff/
>
>
> Testing
> -------
>
> avoid an unnecesary debug crash.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121106/0863fd77/attachment.htm>
More information about the kde-core-devel
mailing list