Review Request: This change will allow the user to see keyboard layout visually

Andriy Rysin arysin at gmail.com
Tue Nov 6 04:53:44 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107202/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 4:53 a.m.)


Review request for KDE Runtime and Shaun Reich.


Changes
-------

Improved formatting and naming, some other optimizations and cleanup


Description
-------

Keyboard layout preview feature


Diffs (updated)
-----

  kcontrol/keyboard/CMakeLists.txt 29de717975d37949448a922c2297674a796a97c1 
  kcontrol/keyboard/Messages.sh 0779aacf810c086c424d4ff946bbcb800492eb84 
  kcontrol/keyboard/kcm_add_layout_dialog.h 6c6a795161d95d5203b5943ead6a7787e29ffd67 
  kcontrol/keyboard/kcm_add_layout_dialog.cpp 34c97163d9267da34ad948347f7cc35b556fdaeb 
  kcontrol/keyboard/kcm_add_layout_dialog.ui b73080d08d6281c4f67d079ab016a3df50821012 
  kcontrol/keyboard/kcm_keyboard.ui 22968e8644cae700efe505fde437d332aa9514ed 
  kcontrol/keyboard/kcm_keyboard_widget.h fa912c7f7daa497c20e3ce7ec4e40882d7d980af 
  kcontrol/keyboard/kcm_keyboard_widget.cpp e1bd830bca8d308470dbba40e5e5a0127672798b 
  kcontrol/keyboard/preview/TODO PRE-CREATION 
  kcontrol/keyboard/preview/kbpreviewframe.h PRE-CREATION 
  kcontrol/keyboard/preview/kbpreviewframe.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keyaliases.h PRE-CREATION 
  kcontrol/keyboard/preview/keyaliases.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keyboardlayout.h PRE-CREATION 
  kcontrol/keyboard/preview/keyboardlayout.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keyboardpainter.h PRE-CREATION 
  kcontrol/keyboard/preview/keyboardpainter.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keysym2ucs.h PRE-CREATION 
  kcontrol/keyboard/preview/keysym2ucs.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keysymbols.h PRE-CREATION 
  kcontrol/keyboard/preview/keysymbols.cpp PRE-CREATION 
  kcontrol/keyboard/preview/keysymhelper.h PRE-CREATION 
  kcontrol/keyboard/preview/keysymhelper.cpp PRE-CREATION 
  kcontrol/keyboard/x11_helper.cpp fdadeeb851bac7511dc924a310c02f6f8a76bc84 

Diff: http://git.reviewboard.kde.org/r/107202/diff/


Testing
-------


Screenshots
-----------

Keyboard Layout Preview
  http://git.reviewboard.kde.org/r/107202/s/813/


Thanks,

Andriy Rysin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121106/e09b2758/attachment.htm>


More information about the kde-core-devel mailing list