Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103610/#review14279
-----------------------------------------------------------


Causes compilation failure of kdelibs:

/local/git/KDE/libs/kdelibs/kio/kio/tcpslavebase.cpp: In member function 'int KIO::TCPSlaveBase::connectToHost(const QString&, quint16, QString*)':
/local/git/KDE/libs/kdelibs/kio/kio/tcpslavebase.cpp:460:1: error: control reaches end of non-void function [-Werror=return-type]

- Christoph Feck


On May 23, 2012, 2:01 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103610/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 2:01 p.m.)
> 
> 
> Review request for kdelibs and Thiago Macieira.
> 
> 
> Description
> -------
> 
> The attached patch addresses the issue of SSL handshake failure in TcpSlaveBase due to lack of support for disabling SSL compression in Qt. As of 4.8, Qt supports this functionality so this patch implements support for activing that support in KTcpSocket and using it from KIO::TcpSlaveBase so that users will be able to browse SSL protected sites that do not support SSL compression.
> 
> Note that this review request requires https://git.reviewboard.kde.org/r/104958/. 
> 
> 
> This addresses bug 275524.
>     http://bugs.kde.org/show_bug.cgi?id=275524
> 
> 
> Diffs
> -----
> 
>   kio/kio/tcpslavebase.h fea2c08 
>   kio/kio/tcpslavebase.cpp d0f92b4 
> 
> Diff: http://git.reviewboard.kde.org/r/103610/diff/
> 
> 
> Testing
> -------
> 
> Visit the links below before and after the patch:
> 
> https://tim.rz.rwth-aachen.de/mail-lifecycle/
> http://www.suse.com/company/careers/ and click on "Apply Now"
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120530/586fd211/attachment.htm>