Review Request: kjs: Implement JSON.stringify

Bernd Buschinski b.buschinski at googlemail.com
Sun May 27 16:25:58 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
-----------------------------------------------------------

(Updated May 27, 2012, 3:25 p.m.)


Review request for kdelibs.


Changes
-------

- fixed double newline
- fixed "functions" could not be replaced, through replace function

now it passes all ecma JSON.stringify tests

this means removing all 15.12.3* test from broken file (not yet included in diff)


Description
-------

kjs: Implement JSON.stringify

patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse)


Diffs (updated)
-----

  kjs/CMakeLists.txt 1188064 
  kjs/CommonIdentifiers.h 8ee40e8 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonstringify.h PRE-CREATION 
  kjs/jsonstringify.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105057/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120527/f30c6aaa/attachment.htm>


More information about the kde-core-devel mailing list