Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

[Aurélien Gâteau]

> On May 23, 2012, 1:06 p.m., Albert Astals Cid wrote:
> > Does this have unit tests? Would make sense to add a new one forcing this behaviour? What about docs? Should any doc be fixed/improved mentioning the behaviour?

There is no test at the moment for the RunnerManager class. Docs does not need to be updated: it's a bug fix, not a behavior change.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104973/#review14082
-----------------------------------------------------------


On May 17, 2012, 1:18 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104973/
> -----------------------------------------------------------
> 
> (Updated May 17, 2012, 1:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> When RunnerManager::reset() is called, all ThreadWeaver jobs are dequeued, including jobs from other parts of the code. This patch changes this to only dequeue the jobs created by this instance of RunnerManager.
> 
> 
> Diffs
> -----
> 
>   plasma/runnermanager.cpp 49569a3 
> 
> Diff: http://git.reviewboard.kde.org/r/104973/diff/
> 
> 
> Testing
> -------
> 
> I have more than one RunnerManager working at once in a project. Without the patch, only one manager return results.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120523/45d4d8e8/attachment.htm>