Review Request: kjs: Fix UString::toDouble not cutting-off leading unicode spaces

Bernd Buschinski b.buschinski at googlemail.com
Mon May 21 13:42:05 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104858/
-----------------------------------------------------------

(Updated May 21, 2012, 12:42 p.m.)


Review request for kdelibs.


Changes
-------

ok, now fixed in UString

"\u180e6"*7 now also works


Summary (updated)
-----------------

kjs: Fix UString::toDouble not cutting-off leading unicode spaces


Description
-------

kjs: Fix parseFloat not cutting-off leading unicode spaces

parseInt cuts away the leading spaces, like it should, but we don't to it for parseFloat, like we should.
UString::toDouble does remove leading spaces, but only ascii spaces, no unicodespaces.

ECMA 15.1.2.3 Step 2 confirms that leading spaces should be cut

depends on https://git.reviewboard.kde.org/r/104855/


Diffs (updated)
-----

  kjs/ustring.cpp 136efb5 

Diff: http://git.reviewboard.kde.org/r/104858/diff/


Testing
-------

Fixes a couple of ecma parseFloat tests


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120521/efd27171/attachment.htm>


More information about the kde-core-devel mailing list