Review Request: show video previews according to file content instead of mimetype string

Hui Ni shuizhuyuanluo at
Sat May 19 07:54:36 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 19, 2012, 6:54 a.m.)

Review request for Dolphin, KDE Base Apps and Peter Penz.


This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string.
There are container formats which can be either audios or videos.
Besides, the rmvb video files have mimetype of "application/vnd.rn-realmedia", and these files can be recognized as videos correctly now.


  dolphin/src/panels/information/informationpanelcontent.h 1d964f5 
  dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 
  dolphin/src/panels/information/phononwidget.h 1e1ea37 
  dolphin/src/panels/information/phononwidget.cpp 5f0c111 



with no more regressions.


Hui Ni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list