Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103610/
-----------------------------------------------------------

(Updated May 15, 2012, 6:03 p.m.)


Review request for kdelibs and Thiago Macieira.


Changes
-------

Updated the patch. Actually make it work.

@Thiago: do you still object to me adding a setter/getter functions for retreiving the QSslConfiguration from KTcpSocket ?


Description
-------

The attached patch addresses the issue of SSL handshake failure in TcpSlaveBase due to lack of support for disabling SSL compression in Qt. As of 4.8, Qt supports this functionality so this patch implements support for activing that support in KTcpSocket and using it from KIO::TcpSlaveBase so that users will be able to browse SSL protected sites that do not support SSL compression.


This addresses bug 275524.
    http://bugs.kde.org/show_bug.cgi?id=275524


Diffs (updated)
-----

  kdecore/network/ktcpsocket.h 982e5b1 
  kdecore/network/ktcpsocket.cpp 57d54a9 
  kio/kio/tcpslavebase.h fea2c08 
  kio/kio/tcpslavebase.cpp d0f92b4 

Diff: http://git.reviewboard.kde.org/r/103610/diff/


Testing
-------

Visit the site listed in the bug report: 
https://tim.rz.rwth-aachen.de/mail-lifecycle/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120515/10b13257/attachment.htm>