Review Request: kjs: Introduce & use leftFirst parameter in relation check, according to Ecmascript 5.1r6.
Maks Orlovich
maksim at kde.org
Sun May 13 15:07:00 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104906/#review13780
-----------------------------------------------------------
Any performance effect?
- Maks Orlovich
On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104906/
> -----------------------------------------------------------
>
> (Updated May 10, 2012, 7:01 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> kjs: Introduce & use leftFirst parameter in relation check, according to Ecmascript 5.1r6.
>
> This fixes the access order for Greater-than and Less-than-or-equal Operator
>
>
> NOTE: please ignore patch r1, it was the wrong patch, luckily normal View Diff always points to the latest version :)
>
>
> Diffs
> -----
>
> kjs/bytecode/codes.def bcd2e3a
> kjs/operations.h f8a28c8
> kjs/operations.cpp d4c0066
>
> Diff: http://git.reviewboard.kde.org/r/104906/diff/
>
>
> Testing
> -------
>
> ecma 11.8.2 tests
>
>
> Thanks,
>
> Bernd Buschinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120513/f700345d/attachment.htm>
More information about the kde-core-devel
mailing list