Review Request: Move the Preferred Web shorcut selection checkbox into its own column

[David Faure]

> On May 10, 2012, 8:41 a.m., David Faure wrote:
> > Preferred? I'm confused. Aren't the checked keywords the only ones that work, and the other ones are disabled?
> > 
> > IMHO this is enabled/disabled, not preferred (which sounds like the other ones are working, just harder to reach)
> 
> Dawit Alemayehu wrote:
>     Nope. That is exactly the confusion this patch is fixing. The checkbox was originally added, by whomever created the Konqueror search bar, to allow users to select or mark their preferred shortcuts that would appear in the search bar's drop down box. Otherwise, there were too many shortcuts to show there. Additionally, the shortcuts that are marked preferred are now used in application context menus to provide users the options to do quick searches. 
>     
>     Anyhow, when the same type of confusion as yours arose the first time and people opened a bug report about it, I thought I could resolve the issue by adding a checkbox, "Use selected shortcuts only" (now renamed to "Use preferred shortcuts only"), to allow behavior one expected from a checkbox appearing in front of an item on a list. Unfortunately and in hind sight very obviously that did not help at all as is evident from the bug reports listed above. Hence the change to resolve the issue once and for all. I even changed the "Whats This" help into "Tool Tips" to provide quick feedback to the user as to the purpose of those checkboxes.

I see. Good change, then.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104900/#review13653
-----------------------------------------------------------


On May 9, 2012, 8:35 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104900/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 8:35 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The following patch moves the "Preferred/Favorite" web shortcut selection checkbox into its own column to avoid confusion. The new column is marked as "Preferred" and also shows a tool tip message about is functionality. See the screenshot below.
> 
> 
> This addresses bugs 168223 and 218164.
>     http://bugs.kde.org/show_bug.cgi?id=168223
>     http://bugs.kde.org/show_bug.cgi?id=218164
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/ikws/ikwsopts.cpp f1cc481 
>   kurifilter-plugins/ikws/ikwsopts_p.h 9cfc12c 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 440c201 
> 
> Diff: http://git.reviewboard.kde.org/r/104900/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Preferred selection column
>   http://git.reviewboard.kde.org/r/104900/s/563/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120510/183f4b67/attachment.htm>