Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

[Sebastian Kügler]

> On May 9, 2012, 6:30 p.m., Mark Gaiser wrote:
> > Ehh optional perhaps?
> > I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior. I mean, there is a big fat blue focus border that has the purpose of telling the user that the one with the blue border (style dependent) is the one that currently has focus. The blinking cursor is yet another indication that the field has focus. I think that is enough.
> > 
> > Perhaps optional, but please not by default. This is just my opinion and i don't maintain plasma components (nor anything in KDE for that matter). You'd have to wait for a reply from some of the plasma component maintainers to get a final word on this.
> 
> Sebastian Kügler wrote:
>     This just fixes a race condition, I don't quite understand your reservation, Mark?
> 
> David Edmundson wrote:
>     No it doesn't. Currently if you give an item focus you hide the placeholder text. In this patch it only hides placeholder text after you start typing.
> 
> David Edmundson wrote:
>      ^ That reply was at Sebastian where he says it's a fix, where it's actually a large visual change. (reviewboard doesn't really show that very well)

Funny, because I ran into this exact behaviour last night, and to make it work well, I had to resort to using a Timer which calls forceActiveFocus() on the TextArea, not quite intuitive either.

Does anyone have a suggestion which satisfies both usecase without hacks?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104895/#review13617
-----------------------------------------------------------


On May 9, 2012, 4:53 p.m., Sebastian Gottfried wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104895/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 4:53 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Rationale: This allows the application to pre-focus a text field with a
> placeholder text for the user. In the version before this would have
> hidden the placeholder text and it may not have been obvious for user
> what he was expected to enter in the text field.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextArea.qml 2d9e89f 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml 4ed15d9 
> 
> Diff: http://git.reviewboard.kde.org/r/104895/diff/
> 
> 
> Testing
> -------
> 
> Used it in ktouch/next, works fine.
> 
> 
> Screenshots
> -----------
> 
> Form in KTouch
>   http://git.reviewboard.kde.org/r/104895/s/562/
> 
> 
> Thanks,
> 
> Sebastian Gottfried
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120510/b87e6adc/attachment.htm>