Review Request: Move the Preferred Web shorcut selection checkbox into its own column

[Andrea Diamantini]

> On May 9, 2012, 9:34 p.m., Andrea Diamantini wrote:
> > Ship It!

I like it. And code changes seem easy and safe.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104900/#review13627
-----------------------------------------------------------


On May 9, 2012, 8:35 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104900/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 8:35 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The following patch moves the "Preferred/Favorite" web shortcut selection checkbox into its own column to avoid confusion. The new column is marked as "Preferred" and also shows a tool tip message about is functionality. See the screenshot below.
> 
> 
> This addresses bugs 168223 and 218164.
>     http://bugs.kde.org/show_bug.cgi?id=168223
>     http://bugs.kde.org/show_bug.cgi?id=218164
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/ikws/ikwsopts.cpp f1cc481 
>   kurifilter-plugins/ikws/ikwsopts_p.h 9cfc12c 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 440c201 
> 
> Diff: http://git.reviewboard.kde.org/r/104900/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Preferred selection column
>   http://git.reviewboard.kde.org/r/104900/s/563/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120509/07ca81ce/attachment.htm>