Review Request: Plasma Components buttons: first focus, than emit clicked() signal

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104893/#review13626
-----------------------------------------------------------

Ship it!


Good catch, please commit to KDE/4.8 and master or let me know so I'll do it for you.

- Sebastian Kügler


On May 9, 2012, 4:41 p.m., Sebastian Gottfried wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104893/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 4:41 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Otherwise a client wanting to give another QML component the focus in
> reaction to a clicked button has no chance doing so because the button
> will steal the focus again right after the event hander has finished
> executing.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Button.qml 6aab1b2 
>   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 00ffa4c 
> 
> Diff: http://git.reviewboard.kde.org/r/104893/diff/
> 
> 
> Testing
> -------
> 
> Tested the behaviour in ktouch/next, works fine.
> 
> 
> Thanks,
> 
> Sebastian Gottfried
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120509/f7eac02f/attachment.htm>