Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104801/
-----------------------------------------------------------

(Updated May 9, 2012, 6:21 p.m.)


Review request for kdelibs.


Description (updated)
-------

So i was trying to fix this bug: https://bugs.kde.org/show_bug.cgi?id=181531 That only asked for one more shortcut. That issue seems to be a little more complicated than it looks. Till this point KActions could only have a "Primary" and a "Alternate" shortcut. 2 in total which is - in some situations - not enough.

I fixed this by roughly restructuring nearly all of the KShortcut cpp file.

The only thing i'm not quite sure about is how "KShortcut KAction::shortcut(ShortcutTypes type) const" looks right now.. If anyone has some clarification on that one..?


Diffs
-----

  kdeui/actions/kaction.h d877554 
  kdeui/actions/kaction.cpp 309cf82 
  kdeui/shortcuts/kshortcut.h c720830 
  kdeui/shortcuts/kshortcut.cpp e307ab0 

Diff: http://git.reviewboard.kde.org/r/104801/diff/


Testing
-------

I tested this by adding the missing bindings for Dolphin's back/forward and it seems to be working just fine. I can use all available shortcuts.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120509/acf6cd5b/attachment.htm>