Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

Mark Gaiser markg85 at
Wed May 9 19:21:53 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 9, 2012, 6:21 p.m.)

Review request for kdelibs.

Description (updated)

So i was trying to fix this bug: That only asked for one more shortcut. That issue seems to be a little more complicated than it looks. Till this point KActions could only have a "Primary" and a "Alternate" shortcut. 2 in total which is - in some situations - not enough.

I fixed this by roughly restructuring nearly all of the KShortcut cpp file.

The only thing i'm not quite sure about is how "KShortcut KAction::shortcut(ShortcutTypes type) const" looks right now.. If anyone has some clarification on that one..?


  kdeui/actions/kaction.h d877554 
  kdeui/actions/kaction.cpp 309cf82 
  kdeui/shortcuts/kshortcut.h c720830 
  kdeui/shortcuts/kshortcut.cpp e307ab0 



I tested this by adding the missing bindings for Dolphin's back/forward and it seems to be working just fine. I can use all available shortcuts.


Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list