Review Request: dataprotocol: make charset recoding work

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104874/#review13603
-----------------------------------------------------------



kio/kio/dataprotocol.cpp
<http://git.reviewboard.kde.org/r/104874/#comment10793>

    Not sure the comment is still correct. "decoded"? It's not, anymore, right? It's just extracted? Or is it even the full initial URL?



kio/kio/dataprotocol.cpp
<http://git.reviewboard.kde.org/r/104874/#comment10792>

    Why .toUtf8()? Are we sure that this is what the receiver of the data will use, for decoding?
    (I mean in the real case of an application getting the data, not in the unittest)



kio/kio/dataprotocol.cpp
<http://git.reviewboard.kde.org/r/104874/#comment10791>

    This comment isn't applicable anymore, it was the justification for toLocal8Bit().


- David Faure


On May 6, 2012, 6:14 p.m., Rolf Eike Beer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104874/
> -----------------------------------------------------------
> 
> (Updated May 6, 2012, 6:14 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This reworks the code that works with different character sets to actually do the right thing (tm).
> 
> 
> Diffs
> -----
> 
>   kio/kio/dataprotocol.cpp e614476 
>   kio/tests/dataprotocoltest.cpp c8df132 
> 
> Diff: http://git.reviewboard.kde.org/r/104874/diff/
> 
> 
> Testing
> -------
> 
> -build whole kdelibs
> -added more testcases from http://greenbytes.de/tech/tc/datauri
> -all dataprotocol tests pass
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120509/05837236/attachment.htm>