Review Request: Use the focus proxy, if present, as parent of KonqPopupMenu

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104890/#review13602
-----------------------------------------------------------


This makes no sense to me. Popping up a context menu has nothing to do with keyboard focus, and the actual cause for the bug hasn't been identified, apparently. So this is a "blind workaround", which I cannot approve.

- David Faure


On May 9, 2012, 7:13 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104890/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 7:13 a.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The following patch changes the parent widget used when creating a context menu in Konqueror. This is done to prevent unnecessary redraw that seems to occur when clicking on a kwebkitpart component that is currently displaying a flash movie. See bug#298744 for further details. 
> 
> What makes the problem even more confounding is the fact that if the page playing the flash movie is reloaded, either before or after clicking the RMB, then clicking the RMB button to display the context menu afterwards works just fine. It is just the first click that causes the bug.
> 
> 
> This addresses bug 298744.
>     http://bugs.kde.org/show_bug.cgi?id=298744
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp ea1678b 
> 
> Diff: http://git.reviewboard.kde.org/r/104890/diff/
> 
> 
> Testing
> -------
> 
> Made sure the bug reported in bug #298744 is gone after testing the patch.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120509/baa7d557/attachment.htm>