Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

Dawit Alemayehu adawit at
Sat May 5 00:01:17 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 4, 2012, 11:01 p.m.)

Review request for KDE Runtime and David Faure.


Fixed the issues raised by David.


The attached patch does the following:

- Use QDialog::open instead of QDialog::exec to prevent one password dialog from blocking other password dialogs. This fixes the changes committed with which allowed dialog boxes from different applications to be shown so long as they are not for the same site.

- Update the key under which the password is cached if the request url contains a username, but the user change it in the password dialog. IOW, do now allow a password to be stored under different username than the one used to access the site.

- Added the unit test listed in the TODOs along with several more that exercise all of the above changes.

Diffs (updated)

  kpasswdserver/DESIGN 6a128f9 
  kpasswdserver/kpasswdserver.h 66f1f57 
  kpasswdserver/kpasswdserver.cpp b2abbd4 
  kpasswdserver/tests/kpasswdservertest.cpp 38a579b 



Added several additional unit tests to exercise all the changes. See patch.


Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list