Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/#review13442
-----------------------------------------------------------


Very nice, thanks for this! Including the unittests I had marked as "TODO"... great ;-)

Just some minor issues.


kpasswdserver/kpasswdserver.cpp
<http://git.reviewboard.kde.org/r/104817/#comment10577>

    Is this unfinished porting, or old code that can be removed?
    I think the code above is doing it, so I guess the latter.



kpasswdserver/kpasswdserver.cpp
<http://git.reviewboard.kde.org/r/104817/#comment10578>

    Why the qpointer? If there no nested event loop, it can't ibly get deleted before the end of the method.
    No need to make the code more complex.



kpasswdserver/kpasswdserver.cpp
<http://git.reviewboard.kde.org/r/104817/#comment10579>

    Same here. Can't be NULL, can't get deleted during the method -> simple pointer should do.



kpasswdserver/kpasswdserver.cpp
<http://git.reviewboard.kde.org/r/104817/#comment10580>

    Why delete value with QScopedPointer and delete key with "delete"? IMHO simple delete is more readable.



kpasswdserver/tests/kpasswdservertest.cpp
<http://git.reviewboard.kde.org/r/104817/#comment10581>

    Copy/paste error, there's no username in the URL 2 lines below.


- David Faure


On May 1, 2012, 10:36 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104817/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 10:36 p.m.)
> 
> 
> Review request for KDE Runtime and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch does the following:
> 
> - Use QDialog::open instead of QDialog::exec to prevent one password dialog from blocking other password dialogs. This fixes the changes committed with https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from different applications to be shown so long as they are not for the same site.
> 
> - Update the key under which the password is cached if the request url contains a username, but the user change it in the password dialog. IOW, do now allow a password to be stored under different username than the one used to access the site.
> 
> - Added the unit test listed in the TODOs along with several more that exercise all of the above changes.
> 
> 
> Diffs
> -----
> 
>   kpasswdserver/tests/kpasswdservertest.cpp 38a579b 
>   kpasswdserver/DESIGN 6a128f9 
>   kpasswdserver/kpasswdserver.h 66f1f57 
>   kpasswdserver/kpasswdserver.cpp b2abbd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104817/diff/
> 
> 
> Testing
> -------
> 
> Added several additional unit tests to exercise all the changes. See patch.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120504/4d75747e/attachment.htm>