Review Request: kjs: Fix parseFloat not cutting-off leading unicode spaces
Bernd Buschinski
b.buschinski at googlemail.com
Fri May 4 18:40:24 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104858/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
kjs: Fix parseFloat not cutting-off leading unicode spaces
parseInt cuts away the leading spaces, like it should, but we don't to it for parseFloat, like we should.
UString::toDouble does remove leading spaces, but only ascii spaces, no unicodespaces.
ECMA 15.1.2.3 Step 2 confirms that leading spaces should be cut
depends on https://git.reviewboard.kde.org/r/104855/
Diffs
-----
kjs/function.cpp 5f39ae6
Diff: http://git.reviewboard.kde.org/r/104858/diff/
Testing
-------
Fixes a couple of ecma parseFloat tests
Thanks,
Bernd Buschinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120504/eafa61e7/attachment.htm>
More information about the kde-core-devel
mailing list