Review Request: Add warning for searching the complete file system

[Andre Heinecke]

> On May 3, 2012, 7:35 p.m., Mark Gaiser wrote:
> > Let me first say that i have absolutely nothing to say about this. I do have an opinion about this though.
> > I would not like this. If i'm searching i just want to search and certainly don't get a dialog just to confirm my search.
> > 
> > Others might think differently though... Perhaps as an option but disabled by default.
> 
> Kai Uwe Broulik wrote:
>     I guess you should introduce them to Nepomuk and explain them how to efficiently tag their files and find them by their contents instead :P

Thanks for your feedback. I've argued about this with my admins, their argumentation was "The users that know what they are doing just use find"
Their argumentation was: If i use an open razor blade i don't expect a warning before I cut my throat. But if i use an electrical shaver i don't expect it to cut my throat.


But I'll discard this patch, the warning is just annoying and would not solve much. An option to include network file systems (disabled by default) would be a better approach to this problem.

Regards


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104826/#review13382
-----------------------------------------------------------


On May 2, 2012, 7:50 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104826/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 7:50 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> In my company it regularly happens that some "non technical" person, e.g. a secretary or a marketing guy tries to find a file he or she has no idea where it is placed.
> When they use kfind to search the complete file system without using locate this pretty much means a DOS attack on our company network with loads of NFS shares etc.
> 
> Searching the complete filesystem is nearly always wrong but as users are used to it from "Search my Computer" or other indexed search options they might not realize it.
> 
> This Patch adds a confirmation dialog if you want to search / or file:/// recursively without using locate warning you that this might take a very long time and is a resource intensive operation
> 
> 
> Diffs
> -----
> 
>   kfind/kfinddlg.cpp 12b3b7e 
>   kfind/kquery.h 39609f3 
> 
> Diff: http://git.reviewboard.kde.org/r/104826/diff/
> 
> 
> Testing
> -------
> 
> Compiled, tested with regular paths, as well as / and file:///
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120503/1e528459/attachment.htm>