Review Request: PreviewJob supports webpages
Dawit Alemayehu
adawit at kde.org
Thu May 3 18:02:10 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104821/#review13369
-----------------------------------------------------------
Ship it!
Looks good to me.
- Dawit Alemayehu
On May 3, 2012, 4:19 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104821/
> -----------------------------------------------------------
>
> (Updated May 3, 2012, 4:19 p.m.)
>
>
> Review request for KDE Runtime and Dawit Alemayehu.
>
>
> Description
> -------
>
> Make htmlcreator thumbnailer plugin support remote URLs
>
> Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well.
>
> We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE.
>
>
> Diffs
> -----
>
> kioslave/thumbnail/htmlcreator.cpp afbcea2
> kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02
>
> Diff: http://git.reviewboard.kde.org/r/104821/diff/
>
>
> Testing
> -------
>
> Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin).
>
> I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of "silent failures", they would be most welcome :)
>
>
> Screenshots
> -----------
>
> previews for bookmarks
> http://git.reviewboard.kde.org/r/104821/s/554/
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120503/fa04c2f0/attachment.htm>
More information about the kde-core-devel
mailing list