Review Request: PreviewJob supports webpages

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104821/#review13356
-----------------------------------------------------------



kioslave/thumbnail/htmlcreator.cpp
<http://git.reviewboard.kde.org/r/104821/#comment10502>

    Why make this branch statement compute the negation of the bool value ? Why not simply do: const int t = startTimer((url.isLocalFile()?5000:30000));



kioslave/thumbnail/htmlthumbnail.desktop
<http://git.reviewboard.kde.org/r/104821/#comment10499>

    Hmm... I doubt you need to explicitly add protocols by name if you also have "KIO" in this list. You can just use KIO.


- Dawit Alemayehu


On May 3, 2012, 3:20 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104821/
> -----------------------------------------------------------
> 
> (Updated May 3, 2012, 3:20 p.m.)
> 
> 
> Review request for KDE Runtime and Dawit Alemayehu.
> 
> 
> Description
> -------
> 
> Make htmlcreator thumbnailer plugin support remote URLs
> 
> Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well.
> 
> We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE.
> 
> 
> Diffs
> -----
> 
>   kioslave/thumbnail/htmlcreator.cpp afbcea2 
>   kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02 
> 
> Diff: http://git.reviewboard.kde.org/r/104821/diff/
> 
> 
> Testing
> -------
> 
> Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin).
> 
> I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of "silent failures", they would be most welcome :)
> 
> 
> Screenshots
> -----------
> 
> previews for bookmarks
>   http://git.reviewboard.kde.org/r/104821/s/554/
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120503/1698d045/attachment.htm>